On 8/26/24 12:17, Thomas Bogendoerfer wrote:
On Mon, 26 Aug 2024 11:41:19 +0200 Jiri Pirko <j...@resnulli.us> wrote:Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote:For PFs, which don't support SRIOV_LAG, there is no pf->lag struct allocated. So before accessing pf->lag a NULL pointer check is needed. Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse.de>You need to add a "fixes" tag blaming the commit that introduced the bug.
Would be also good to CC the author.
of course...
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
bonded interface")
the bug was introduced later, the tag should be:Fixes: ec5a6c5f79ed ("ice: process events created by lag netdev event handler")
The mentioned commit extracted code into ice_lag_move_new_vf_nodes(), and there is just one call to this function by now, just after releasing lag_mutex, so would be good to change the semantics of ice_lag_move_new_vf_nodes() to "only for lag-enabled flows, with lag_mutex held", and fix the call to it to reflect that.
Should I resend the patch ?
sometimes that is not strictly needed, but after two possible tags mentioned that's the best way :)
Thomas.
