> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Daiwei Li > Sent: Wednesday, August 14, 2024 10:26 AM > To: intel-wired-...@lists.osuosl.org > Cc: Daiwei Li <daiwe...@google.com>; Neftin, Sasha <sasha.nef...@intel.com>; > Gomes, Vinicius <vinicius.go...@intel.com>; net...@vger.kernel.org; > richardcoch...@gmail.com; k...@linutronix.de; linux-ker...@vger.kernel.org; > eduma...@google.com; Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kits...@intel.com>; k...@kernel.org; > pab...@redhat.com; da...@davemloft.net > Subject: [Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync > interrupts for 82580 > > 82580 NICs have a hardware bug that makes it necessary to write into the > TSICR (TimeSync Interrupt Cause) register to clear it: > https://lore.kernel.org/all/cdcb8be0.1ec2c%25matthew.v...@intel.com/ > > Add a conditional so only for 82580 we write into the TSICR register, so we > don't risk losing events for other models. > > Without this change, when running ptp4l with an Intel 82580 card, I get the > following output: > > > timed out while polling for tx timestamp increasing > > tx_timestamp_timeout or increasing kworker priority may correct this > > issue, but a driver bug likely causes it > > This goes away with this change. > > This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync > events"). > > Fixes: ee14cc9ea19b ("igb: Fix missing time sync events") > Closes: > https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w...@mail.gmail.com/ > Tested-by: Daiwei Li <daiwe...@google.com> > Suggested-by: Vinicius Costa Gomes <vinicius.go...@intel.com> > Signed-off-by: Daiwei Li <daiwe...@google.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel)
