> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Jacob > Keller > Sent: Wednesday, August 7, 2024 2:16 AM > To: Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Intel Wired LAN > <intel-wired-...@lists.osuosl.org>; "netdev netdev"@vger.kernel.org > Cc: Temerkhanov, Sergey <sergey.temerkha...@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kits...@intel.com>; Kolacinski, Karol > <karol.kolacin...@intel.com>; Wierzbicki, Jacek <jacek.wierzbi...@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-next 6/7] ice: remove unnecessary > control queue cmd_buf arrays > > The driver allocates a cmd_buf array in addition to the desc_buf array. > This array stores an ice_sq_cd command details structure for each entry in > the control queue ring. > > The contents of the structure are copied from the value passed in via > ice_sq_send_cmd, and include only a pointer to storage for the write back > descriptor contents. > > Originally this array was intended to support asynchronous completion > including features such as a callback function. This support was never > implemented. All that exists today is needless copying and resetting of a > cmd_buf array that is otherwise functionally unused. > > Since we do not plan to implement asynchronous completions, drop this > unnecessary memory and logic. This saves memory for each control queue, and > avoids the pointless copying and memset. > > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > --- > drivers/net/ethernet/intel/ice/ice_controlq.h | 3 --- > drivers/net/ethernet/intel/ice/ice_controlq.c | 29 ++------------------------- > 2 files changed, 2 insertions(+), 30 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel)
