> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Aleksandr Mishin > Sent: Wednesday, July 10, 2024 6:10 PM > To: Anirudh Venkataramanan <anirudh.venkatarama...@intel.com> > Cc: lvc-proj...@linuxtesting.org; intel-wired-...@lists.osuosl.org; > linux-ker...@vger.kernel.org; Kitszel, Przemyslaw > <przemyslaw.kits...@intel.com>; Eric Dumazet <eduma...@google.com>; Nguyen, > Anthony L <anthony.l.ngu...@intel.com>; Aleksandr Mishin > <amis...@t-argos.ru>; net...@vger.kernel.org; Jakub Kicinski > <k...@kernel.org>; Paolo Abeni <pab...@redhat.com>; David S. Miller > <da...@davemloft.net> > Subject: [Intel-wired-lan] [PATCH net-next v4] ice: Adjust over allocation of > memory in ice_sched_add_root_node() and ice_sched_add_node() > > In ice_sched_add_root_node() and ice_sched_add_node() there are calls to > devm_kcalloc() in order to allocate memory for array of pointers to > 'ice_sched_node' structure. But incorrect types are used as sizeof() > arguments in these calls (structures instead of pointers) which leads to over > allocation of memory. > > Adjust over allocation of memory by correcting types in devm_kcalloc() > sizeof() arguments. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > Signed-off-by: Aleksandr Mishin <amis...@t-argos.ru> > --- > v4: > - Remove Suggested-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > - Add Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > > (https://lore.kernel.org/all/6d8ac0cf-b954-4c12-8b5b-e172c850e...@intel.com/) > v3: https://lore.kernel.org/all/20240708182736.8514-1-amis...@t-argos.ru/ > - Update comment and use the correct entities as suggested by Przemek > v2: https://lore.kernel.org/all/20240706140518.9214-1-amis...@t-argos.ru/ > - Update comment, remove 'Fixes' tag and change the tree from 'net' to > 'net-next' as suggested by Simon > (https://lore.kernel.org/all/20240706095258.gb1481...@kernel.org/) > v1: https://lore.kernel.org/all/20240705163620.12429-1-amis...@t-argos.ru/ > > drivers/net/ethernet/intel/ice/ice_sched.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A Contingent worker at Intel)
