> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Karol
> Kolacinski
> Sent: Thursday, June 20, 2024 5:57 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Keller, Jacob E <jacob.e.kel...@intel.com>; net...@vger.kernel.org;
> Kolacinski, Karol <karol.kolacin...@intel.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>
> Subject: [Intel-wired-lan] [PATCH v2 iwl-net 2/3] ice: Don't process extts if
> PTP is disabled
>
> From: Jacob Keller <jacob.e.kel...@intel.com>
>
> The ice_ptp_extts_event() function can race with ice_ptp_release() and result
> in a NULL pointer dereference which leads to a kernel panic.
>
> Panic occurs because the ice_ptp_extts_event() function calls
> ptp_clock_event() with a NULL pointer. The ice driver has already released
> the PTP clock by the time the interrupt for the next external timestamp event
> occurs.
>
> To fix this, modify the ice_ptp_extts_event() function to check the PTP state
> and bail early if PTP is not ready.
>
> Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins")
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacin...@intel.com>
> ---
> V1 -> V2: removed unnecessary hunk of code and adjusted commit message
>
> drivers/net/ethernet/intel/ice/ice_ptp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A
Contingent worker at Intel)
