On Thu, Jun 06, 2024 at 01:24:53PM +0200, Michal Swiatkowski wrote:
> From: Piotr Raczynski <piotr.raczyn...@intel.com>
>
> Make devlink allocation function generic to use it for PF and for SF.
>
> Add function for SF devlink port creation. It will be used in next
> patch.
>
> Create header file for subfunction device. Define subfunction device
> structure there as it is needed for devlink allocation and port
> creation.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Piotr Raczynski <piotr.raczyn...@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkow...@linux.intel.com>
Thanks Piotr,
I believe this addresses Jiri's review of v4.
And the minor nit below not withstanding, this looks good to me.
Reviewed-by: Simon Horman <ho...@kernel.org>
...
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> b/drivers/net/ethernet/intel/ice/devlink/devlink.c
...
> @@ -1422,6 +1425,7 @@ static void ice_devlink_free(void *devlink_ptr)
> * Allocate a devlink instance for this device and return the private area as
> * the PF structure. The devlink memory is kept track of through devres by
> * adding an action to remove it when unwinding.
> + *
> */
> struct ice_pf *ice_allocate_pf(struct device *dev)
> {
nit: this hunk seems unrelated to the rest of the patch.
...
