On Wed, Jun 05, 2024 at 04:17:45PM +0200, Marcin Szycik wrote: > Adding/updating VSI list rule, as well as allocating/freeing VSI list > resource are called several times with type ICE_SW_LKUP_LAST, which fails > because ice_update_vsi_list_rule() and ice_aq_alloc_free_vsi_list() > consider it invalid. Allow calling these functions with ICE_SW_LKUP_LAST. > > This fixes at least one issue in switchdev mode, where the same rule with > different action cannot be added, e.g.: > > tc filter add dev $PF1 ingress protocol arp prio 0 flower skip_sw \ > dst_mac ff:ff:ff:ff:ff:ff action mirred egress redirect dev $VF1_PR > tc filter add dev $PF1 ingress protocol arp prio 0 flower skip_sw \ > dst_mac ff:ff:ff:ff:ff:ff action mirred egress redirect dev $VF2_PR > > Fixes: 0f94570d0cae ("ice: allow adding advanced rules") > Suggested-by: Michal Swiatkowski <michal.swiatkow...@linux.intel.com> > Reviewed-by: Michal Swiatkowski <michal.swiatkow...@linux.intel.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > Signed-off-by: Marcin Szycik <marcin.szy...@linux.intel.com>
Reviewed-by: Simon Horman <ho...@kernel.org>