On Mon, May 13, 2024 at 10:37:28AM +0200, Michal Swiatkowski wrote:
> Keep the same flow of port representor creation, but instead of general
> attach function create helpers for specific representor type.
>
> Store function pointer for add and remove representor.
>
> Type of port representor can be also known based on VSI type, but it
> is more clean to have it directly saved in port representor structure.
>
> Add devlink lock for whole port representor creation and destruction.
>
> Reviewed-by: Wojciech Drewek <wojciech.dre...@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkow...@linux.intel.com>
nit: In subject, reprresentor -> representor
> ---
> .../ethernet/intel/ice/devlink/devlink_port.h | 1 +
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 74 +++++++++++-----
> drivers/net/ethernet/intel/ice/ice_eswitch.h | 11 +--
> drivers/net/ethernet/intel/ice/ice_repr.c | 88 +++++++++----------
> drivers/net/ethernet/intel/ice/ice_repr.h | 16 +++-
> drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +-
> drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +-
> 7 files changed, 121 insertions(+), 77 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> index e4acd855d9f9..6e14b9e4d621 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> @@ -23,6 +23,7 @@ struct ice_dynamic_port {
> struct devlink_port devlink_port;
> struct ice_pf *pf;
> struct ice_vsi *vsi;
> + unsigned long repr_id;
nit: Please add an entry for repr_id to the Kernel doc for this structure.
And also the attached field which is added by the last patch
of this series.
> u32 sfnum;
> };
>
...
