I have tested this patch from ADQ perspective and it is working fine. [root@BP-node3-BINDU ~]# tc filter add dev ens801f0v0 protocol ip parent ffff: prio 1 flower dst_ip 192.168.1.10 ip_proto tcp dst_port 12000 ip_flags frag skip_sw hw_tc 1 RTNETLINK answers: Operation not supported We have an error talking to the kernel [root@BP-node3-BINDU ~]# tc filter add dev ens801f0v0 protocol ip parent ffff: prio 1 flower dst_ip 192.168.1.10 ip_proto tcp dst_port 12000 ip_flags frag/firstfrag skip_sw hw_tc 1 RTNETLINK answers: Operation not supported We have an error talking to the kernel [root@BP-node3-BINDU ~]# tc filter add dev ens801f0v0 protocol ip parent ffff: prio 1 flower dst_ip 192.168.1.10 ip_proto tcp dst_port 12000 skip_sw hw_tc 1 [root@BP-node3-BINDU ~]# tc filter show dev ens801f0v0 root filter parent ffff: protocol ip pref 1 flower chain 0 filter parent ffff: protocol ip pref 1 flower chain 0 handle 0x1 hw_tc 1 eth_type ipv4 ip_proto tcp dst_ip 192.168.1.10 dst_port 12000 skip_sw in_hw in_hw_count 1 [root@BP-node3-BINDU ~]# tc filter add dev ens801f0v0 protocol ip parent ffff: prio 1 flower dst_ip 192.168.1.10 ip_proto tcp dst_port 12000 ip_flags frag/firstfrag hw_tc 1 [root@BP-node3-BINDU ~]# tc filter show dev ens801f0v0 root filter parent ffff: protocol ip pref 1 flower chain 0 filter parent ffff: protocol ip pref 1 flower chain 0 handle 0x1 hw_tc 1 eth_type ipv4 ip_proto tcp dst_ip 192.168.1.10 dst_port 12000 skip_sw in_hw in_hw_count 1 filter parent ffff: protocol ip pref 1 flower chain 0 handle 0x2 hw_tc 1 eth_type ipv4 ip_proto tcp dst_ip 192.168.1.10 dst_port 12000 ip_flags frag/firstfrag not_in_hw
Thanks, Sujai B > -----Original Message----- > From: Buvaneswaran, Sujai > Sent: Monday, May 6, 2024 3:03 PM > To: Asbjørn Sloth Tønnesen <a...@fiberby.net>; intel-wired- > l...@lists.osuosl.org > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; Eric Dumazet > <eduma...@google.com>; Nguyen, Anthony L > <anthony.l.ngu...@intel.com>; Jakub Kicinski <k...@kernel.org>; Paolo > Abeni <pab...@redhat.com>; David S. Miller <da...@davemloft.net> > Subject: RE: [Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate control > flags > > Hi Asbjørn, > > I have tried the above steps as well and still issue is seen while enabling HW > offload on iavf interface. > > [root@cbl-mariner ~]# ethtool -K ens5f0v0 hw-tc-offload on Actual changes: > hw-tc-offload: off [requested on] > Could not change any device features > [root@cbl-mariner ~]# tc qdisc add dev ens5f0v0 ingress [root@cbl-mariner > ~]# tc filter add dev ens5f0v0 protocol ip parent ffff: prio 1 flower dst_mac > 3c:fd:fe:a0:d6:70 ip_flags frag skip_sw hw_tc 1 > Error: TC offload is disabled on net device. > We have an error talking to the kernel > > Thanks, > Sujai B > > > -----Original Message----- > > From: Asbjørn Sloth Tønnesen <a...@fiberby.net> > > Sent: Monday, May 6, 2024 2:50 PM > > To: Buvaneswaran, Sujai <sujai.buvaneswa...@intel.com>; intel-wired- > > l...@lists.osuosl.org > > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; Eric Dumazet > > <eduma...@google.com>; Nguyen, Anthony L > <anthony.l.ngu...@intel.com>; > > Jakub Kicinski <k...@kernel.org>; Paolo Abeni <pab...@redhat.com>; > > David S. Miller <da...@davemloft.net> > > Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate > > control flags > > > > Hi Sujai, > > > > Thank you for testing. > > > > On 5/6/24 5:30 AM, Buvaneswaran, Sujai wrote: > > > HW offload is not directly supported on the iavf VF interface. VF > > > traffic can > > be offloaded only through VF port representor device which uses ice driver. > > > > Again, there is a awful lot of flower code in iavf_main.c, if it's not > supported. > > > > Try with: > > ethtool -K $iface hw-tc-offload on > > tc qdisc add dev $iface ingress > > tc filter add dev $iface protocol ip parent ffff: prio 1 flower > > dst_mac > > 3c:fd:fe:a0:d6:70 ip_flags frag skip_sw hw_tc 1 > > > > -- > > Best regards > > Asbjørn Sloth Tønnesen > > Network Engineer > > Fiberby - AS42541
