On Wed, Mar 20 2024 at 12:23, Thomas Gleixner wrote:
> On Tue, Mar 19 2024 at 18:35, lakshmi.sowjany...@intel.com wrote:
>> From: Lakshmi Sowjanya D <lakshmi.sowjany...@intel.com>
>>
>> Add base clock hardware abstraction in clocksource structure.
>>
>> Add clocksource ID for x86 ART(Always Running Timer).
>
> This change log tells the WHAT but not the WHY. You have to add context
> and explanation WHY this change is required and why it makes sense.
>
> Also I think this should be ordered differently:
>
> 1) Add the clocksource_base struct and provide the infrastructure in
> get_device_system_crosststamp()
>
> 2) Make TSC/ART use it
2a) Remove the art to tsc conversion in drivers
2b) Remove art to tsc
> 3) Add the realtime muck
>
> Thanks,
>
> tglx
