> -----Original Message----- > From: Alan Brady <alan.br...@intel.com> > Sent: Thursday, February 22, 2024 11:05 AM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Brady, Alan <alan.br...@intel.com>; Lobakin, > Aleksander <aleksander.loba...@intel.com> > Subject: [PATCH v6 06/11 iwl-next] idpf: add async_handler for MAC filter > messages > > There are situations where the driver needs to add a MAC filter but > we're explicitly not allowed to sleep so we can wait for a virtchnl > message to complete. > > This adds an async_handler for asynchronously sent messages for MAC > filters so that we can better handle if there's an error of some kind. > If success we don't need to do anything else, but if we failed to > program the new filter we really should remove it from our list of MAC > filters. If we don't remove bad filters, what I expect to happen is > after a reset of some kind we try to program the MAC filter again and it > fails again. This is clearly wrong and I would expect to be confusing > for the user. > > It could also be the failure is for a delete MAC filter message but > those filters get deleted regardless. Not much we can do about a delete > failure. > > Tested-by: Alexander Lobakin <aleksander.loba...@intel.com> > Signed-off-by: Alan Brady <alan.br...@intel.com> > --- > .../net/ethernet/intel/idpf/idpf_virtchnl.c | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > index 0f14860efa28..d1107507a98c 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
Tested-by: Krishneil Singh <krishneil.k.si...@intel.com>
