Dear Jesse, dear Simon,
Am 21.02.24 um 11:35 schrieb Simon Horman:
On Tue, Feb 20, 2024 at 08:48:28AM -0800, Jesse Brandeburg wrote:
On 2/19/2024 1:15 AM, Simon Horman wrote:
On Sat, Feb 10, 2024 at 02:01:08PM -0800, Jesse Brandeburg wrote:
The igb driver was pre-declaring tons of functions just so that it could
have an early declaration of the pci_driver struct.
Delete a bunch of the declarations and move the struct to the bottom of the
file, after all the functions are declared.
Reviewed-by: Alan Brady <alan.br...@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
- .probe = igb_probe,
- .remove = igb_remove,
-#ifdef CONFIG_PM
- .driver.pm = &igb_pm_ops,
-#endif
- .shutdown = igb_shutdown,
+ .probe = igb_probe,
+ .remove = igb_remove,
+ .driver.pm = &igb_pm_ops,
the line above causes a build failure if CONFIG_PM is not set.
Yeah I missed that, but do we care since patch 2/2 then fixes it?
Right. TBH I wrote the above before noticing 2/2.
And I guess it is not a big deal either way.
In my opinion, to ease bisecting, each commit should build, so if a
build failure can be avoided, it’d be great if you could fix this before
committing.
Kind regards,
Paul
