On Thu Jan 25 2024, Andrew Lunn wrote: > On Thu, Jan 25, 2024 at 08:31:54AM +0100, Kurt Kanzenbach wrote: >> On Wed Jan 24 2024, Andrew Lunn wrote: >> > On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: >> >> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs >> >> from user space using the netdev trigger. The LEDs are named as >> >> igc-<bus><device>-<led> to be easily identified. >> >> >> >> Offloading activity and link speed is supported. Tested on Intel i225. >> > >> > Nice to see something not driver by phylib/DSA making use of LEDs. >> > >> > Is there no plain on/off support? Ideally we want that for software >> > blinking for when a mode is not supported. >> >> Plain on and off is supported is supported, too. Should be possible to >> implement brightness_set(). > > Great. > > Its actually better to first implement brightness_set(). That gives > you full support for everything the netdev trigger has. Then add > offload, which is optional, and will fall back to software for modes > which cannot be offloaded.
Understood. I'll do that. Thanks, Kurt
signature.asc
Description: PGP signature
