> -----Original Message-----
> From: Simon Horman <[email protected]>
> Sent: Monday, January 15, 2024 2:37 AM
> To: Kolacinski, Karol <[email protected]>
> Cc: [email protected]; [email protected]; Nguyen, Anthony
> L
> <[email protected]>; Brandeburg, Jesse
> <[email protected]>; Keller, Jacob E <[email protected]>
> Subject: Re: [PATCH v5 iwl-next 3/6] ice: rename verify_cached to
> has_ready_bitmap
>
> On Mon, Jan 08, 2024 at 01:47:14PM +0100, Karol Kolacinski wrote:
> > From: Jacob Keller <[email protected]>
> >
> > The tx->verify_cached flag is used to inform the Tx timestamp tracking
> > code whether it needs to verify the cached Tx timestamp value against
> > a previous captured value. This is necessary on E810 hardware which does
> > not have a Tx timestamp ready bitmap.
> >
> > In addition, we currently rely on the fact that the
> > ice_get_phy_tx_tstamp_ready() function returns all 1s for E810 hardware.
> > Instead of introducing a brand new flag, rename and verify_cached to
> > has_ready_bitmap, inverting the relevant checks.
>
> From the above I understand what this patch does.
> But not why this change is desirable.
> I think it would be useful to state that.
>
The main motivation is that it is easier to understand the resulting behavior
than to rely on a hidden assumption of how ice_get_phy_tx_stamp_ready() works.
> Also, perhaps it just me, but it seems that
> renaming verify_cached and weeding out assumptions
> about the return value of ice_get_phy_tx_tstamp_ready()
> are separate, albeit related changes:
> I might have gone for two patches instead of one.
>
It could possibly be split up. The motivation was to stop relying on the fact
that ice_get_phy_tx_tstamp_ready() returns all 1s, since we already know
whether we can safely check it or not. But then using "verify_cached" to do so
reads weird with the code because its name no longer clearly indicates its
purpose. Instead, we rename it to better reflect its intention.
Thanks,
Jake
> > Signed-off-by: Jacob Keller <[email protected]>
> > Signed-off-by: Karol Kolacinski <[email protected]>
> > Reviewed-by: Jacob Keller <[email protected]>
>
> ...
