> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Kunwu
> Chan
> Sent: Friday, December 8, 2023 8:50 AM
> To: Brandeburg, Jesse <jesse.brandeb...@intel.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>; da...@davemloft.net; eduma...@google.com;
> k...@kernel.org; pab...@redhat.com; jeffrey.t.kirs...@intel.com;
> shannon.nel...@amd.com
> Cc: Kunwu Chan <chen...@kylinos.cn>; Kunwu Chan <kunwu.c...@hotmail.com>;
> net...@vger.kernel.org; linux-ker...@vger.kernel.org; Lobakin, Aleksander
> <aleksander.loba...@intel.com>; intel-wired-...@lists.osuosl.org; Simon
> Horman <ho...@kernel.org>
> Subject: [Intel-wired-lan] [PATCH v5 iwl-next] i40e: Use correct buffer size
> in i40e_dbg_command_read
>
> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256.
>
> Improve readability and maintainability by replacing a hardcoded string
> allocation and formatting by the use of the kasprintf() helper.
>
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> Suggested-by: Simon Horman <ho...@kernel.org>
> Suggested-by: Alexander Lobakin <aleksander.loba...@intel.com>
> Suggested-by: Tony Nguyen <anthony.l.ngu...@intel.com>
> Cc: Kunwu Chan <kunwu.c...@hotmail.com>
> Signed-off-by: Kunwu Chan <chen...@kylinos.cn>
> ---
> v2
> - Update the size calculation with IFNAMSIZ and
> sizeof(i40e_dbg_command_buf)
> v3
> - Use kasprintf to improve readability and maintainability
> v4
> - Fix memory leak in error path
> v5
> - Change the order of labels
> ---
> .../net/ethernet/intel/i40e/i40e_debugfs.c | 20 ++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A
Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
