> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Wednesday, December 6, 2023 2:01 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>; Brandeburg, Jesse
> <jesse.brandeb...@intel.com>; Lobakin, Aleksander
> <aleksander.loba...@intel.com>; marcin.szy...@linux.intel.com;
> ho...@kernel.org; net...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 00/15] intel: use bitfield
> operations
>
> After repeatedly getting review comments on new patches, and sporadic
> patches to fix parts of our drivers, we should just convert the Intel code to
> use
> FIELD_PREP() and FIELD_GET(). It's then "common" in the code and hopefully
> future change-sets will see the context and do-the-right-thing.
>
> In v2 there were a few conversions to use leXX_{get,set,encode}_bits() where
> possible.
>
> This conversion was done with a coccinelle script which is mentioned in the
> commit messages. Generally there were only a couple conversions that were
> "undone" after the automatic changes because they tried to convert a non-
> contiguous mask.
>
> Patch 1 is required at the beginning of this series to fix a "forever"
> issue in the e1000e driver that fails the compilation test after conversion
> because the shift / mask was out of range.
>
> The second patch just adds all the new #includes in one go.
>
> The patch titled: "ice: fix pre-shifted bit usage" is needed to allow the use
> of
> the FIELD_* macros and fix up the unexpected "shifts included"
> defines found while creating this series.
>
> The rest are the conversion to use FIELD_PREP()/FIELD_GET(), and the
> occasional leXX_{get,set,encode}_bits() call, as suggested by Alex.
>
> CC: Alexander Lobakin <aleksander.loba...@intel.com>
> Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com>
> Reviewed-by: Simon Horman <ho...@kernel.org>
> Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
> ---
> v2: add some conversions to the ice patch, add the idpf patch, respond to
> comments from reviewers, resulting in more le*_bits usage (Olek), add more
> reviewed-bys, see each individual patch for details. changed title of
> 0/0
> v1: original
>
Tested-by: Rafal Romanowski <rafal.romanow...@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
