On Tue, Dec 05, 2023 at 05:09:48PM +0100, Przemek Kitszel wrote: > On 12/5/23 16:26, Pawel Chmielewski wrote: > > From: Ngai-Mint Kwan <ngai-mint.k...@intel.com> > > > > Getting coalesce settings while reset is in progress can cause NULL > > pointer deference bug. > > If under reset, abort get coalesce for ethtool. > > > > Signed-off-by: Ngai-Mint Kwan <ngai-mint.k...@intel.com> > > Reviewed-by: Mateusz Polchlopek <mateusz.polchlo...@intel.com> > > Signed-off-by: Pawel Chmielewski <pawel.chmielew...@intel.com> > > --- > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c > > b/drivers/net/ethernet/intel/ice/ice_ethtool.c > > index bde9bc74f928..2d565cc484a0 100644 > > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c > > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c > > @@ -3747,6 +3747,9 @@ __ice_get_coalesce(struct net_device *netdev, struct > > ethtool_coalesce *ec, > > struct ice_netdev_priv *np = netdev_priv(netdev); > > struct ice_vsi *vsi = np->vsi; > > + if (ice_is_reset_in_progress(vsi->back->state)) > > + return -EBUSY; > > + > > if (q_num < 0) > > q_num = 0; > > Sorry for a late review, > This asks for a Fixes: tag, and targeting at iwl-net instead :)
Will fix the target, add the tag and send v2 right away :) _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
