Hi Kurt,

>+      if (rule->filter.match_flags & IGC_FILTER_FLAG_VLAN_ETYPE) {
>+              fsp->flow_type |= FLOW_EXT;
>+              fsp->h_ext.vlan_etype = rule->filter.vlan_etype;
>+              fsp->m_ext.vlan_etype = ETHER_TYPE_FULL_MASK;
[Suman] User can provide mask for vlan-etype as well. Why not take that rather 
than hard coding it? I checked you are already doing the same for TCI in the 
other patch.
>+      }
>+
>       if (rule->filter.match_flags & IGC_FILTER_FLAG_VLAN_TCI) {
>               fsp->flow_type |= FLOW_EXT;
>               fsp->h_ext.vlan_tci = htons(rule->filter.vlan_tci);
>--
>2.39.2
>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Reply via email to