On Tue, Nov 21, 2023 at 01:19:15PM -0800, Jesse Brandeburg wrote: > While converting to FIELD_PREP() and FIELD_GET(), it was noticed that > some of the RSS defines had *included* the shift in their definitions. > This is completely outside of normal, such that a developer could easily > make a mistake and shift at the usage site (like when using > FIELD_PREP()). > > Rename the defines and set them to the "pre-shifted values" so they > match the template the driver normally uses for masks and the member > bits of the mask, which also allows the driver to use FIELD_PREP > correctly with these values. Use GENMASK() for this changed MASK value. > > Do the same for the VLAN EMODE defines as well. > > Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
Reviewed-by: Simon Horman <ho...@kernel.org> _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
