On Tue, Nov 21, 2023 at 01:19:13PM -0800, Jesse Brandeburg wrote: > Refactor iavf driver to use FIELD_PREP(), which reduces lines of code > and adds clarity of intent. > > This code was generated by the following coccinelle/spatch script and > then manually repaired. > > Clean up a couple spots in the code that had repetitive > y = cpu_to_*((blah << blah_blah) & blat) > y |= cpu_to_*((blahs << blahs_blahs) & blats) > to > x = FIELD_PREP(blat blah) > x |= FIELD_PREP(blats, blahs) > y = cpu_to_*(x); > > @prep@ > constant shift,mask; > expression a; > @@ > -((a << shift) & mask) > +FIELD_PREP(mask, a) > > Cc: Julia Lawall <julia.law...@inria.fr> > Cc: Ahmed Zaki <ahmed.z...@intel.com> > Reviewed-by: Marcin Szycik <marcin.szy...@linux.intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
Reviewed-by: Simon Horman <ho...@kernel.org> _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan