Thu, Oct 12, 2023 at 03:33:15PM CEST, pawel.chmielew...@intel.com wrote:
>> >diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
>>
>> Why you put this into ioctl.c?
>>
>> Can't this be put into include/linux/linkmode.h as a static helper as
>> well?
>
>I'm a little bit confused, include/linux/linkmode.h doesn't contain
>similar ethtool helpers.. Did you maybe meant ethtool.h?
I just looked there linkmode_set_bit_array is. ethtool.h might be the
place.
>
>>
>> >index 0b0ce4f81c01..34507691fc9d 100644
>> >--- a/net/ethtool/ioctl.c
>> >+++ b/net/ethtool/ioctl.c
>> >@@ -3388,3 +3388,16 @@ void ethtool_rx_flow_rule_destroy(struct
>> >ethtool_rx_flow_rule *flow)
>> > kfree(flow);
>> > }
>> > EXPORT_SYMBOL(ethtool_rx_flow_rule_destroy);
>> >+
>> >+void ethtool_forced_speed_maps_init(struct ethtool_forced_speed_map *maps,
>> >+ u32 size)
>> >+{
>> >+ for (u32 i = 0; i < size; i++) {
>> >+ struct ethtool_forced_speed_map *map = &maps[i];
>> >+
>> >+ linkmode_set_bit_array(map->cap_arr, map->arr_size, map->caps);
>> >+ map->cap_arr = NULL;
>> >+ map->arr_size = 0;
>> >+ }
>> >+}
>> >+EXPORT_SYMBOL(ethtool_forced_speed_maps_init);
>> >--
>> >2.37.3
>> >
>> >
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
