On ti, 2016-09-06 at 07:19 +0100, Chris Wilson wrote: > @@ -3725,7 +3723,6 @@ int intel_freq_opcode(struct drm_i915_private > *dev_priv, int val); > * act upon the intermediate value, possibly leading to corruption and > * machine death. You have been warned. > */
I'd update the comment, it's about interpreting the intermediate value now. And maybe explicitly state that we do not do 64-bit writes. > -#define I915_WRITE64(reg, val) > dev_priv->uncore.funcs.mmio_writeq(dev_priv, (reg), (val), true) > #define I915_READ64(reg) dev_priv->uncore.funcs.mmio_readq(dev_priv, > (reg), true) > Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
