>> > - default_desc->flags = CMD_DESC_SKIP; >> > + default_desc->cmd.value = cmd_header; >> > + default_desc->cmd.mask = 0xffff0000; >> Where did you pluck this mask from? > > It is the most general cmd header mask. > > #define MIN_OPCODE_SHIFT 16 > cmd.mask = ~0u << MIN_OPCODE_SHIFT > ? Reviewed-by: Matthew Auld <matthew.a...@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
- Re: [Intel-gfx] [PATCH 3/9] drm/i915/cmdparser: ... Matthew Auld
- [Intel-gfx] [PATCH 2/9] drm/i915/cmdparser: Add the TIMESTAMP... Chris Wilson
- [Intel-gfx] [PATCH 5/9] drm/i915/cmdparser: Improve hash func... Chris Wilson
- [Intel-gfx] [PATCH 6/9] drm/i915/cmdparser: Compare against t... Chris Wilson
- Re: [Intel-gfx] [PATCH 6/9] drm/i915/cmdparser: Compare ... Matthew Auld
- Re: [Intel-gfx] [PATCH 6/9] drm/i915/cmdparser: Comp... Chris Wilson
- Re: [Intel-gfx] [PATCH 6/9] drm/i915/cmdparser: ... Matthew Auld
- [Intel-gfx] [PATCH 1/9] drm/i915/cmdparser: Make initialisati... Chris Wilson
- [Intel-gfx] [PATCH 4/9] drm/i915/cmdparser: Only cache the ds... Chris Wilson
- [Intel-gfx] [PATCH 8/9] drm/i915/cmdparser: Use binary search... Chris Wilson
- [Intel-gfx] [PATCH 7/9] drm/i915/cmdparser: Check for SKIP de... Chris Wilson
- [Intel-gfx] [PATCH 9/9] drm/i915/cmdparser: Accelerate copies... Chris Wilson