On ti, 2016-08-16 at 11:42 +0100, Chris Wilson wrote:
> @@ -622,6 +622,12 @@ int i915_gem_obj_prepare_shmem_read(struct
> drm_i915_gem_object *obj,
> if (ret)
> return ret;
>
> + ret = i915_gem_object_get_pages(obj);
> + if (ret)
> + return ret;
> +
> + i915_gem_object_pin_pages(obj);
The pin_pages function is now mustcheck (or I'm lost between series),
so;
ret = i915_gem_object_pin_pages(obj);
if (ret)
goto err;
> int i915_gem_obj_prepare_shmem_write(struct drm_i915_gem_object *obj,
> @@ -664,6 +668,12 @@ int i915_gem_obj_prepare_shmem_write(struct
> drm_i915_gem_object *obj,
> if (ret)
> return ret;
>
> + ret = i915_gem_object_get_pages(obj);
> + if (ret)
> + return ret;
> +
> + i915_gem_object_pin_pages(obj);
> +
Ditto.
With those (or me proved wrong on this);
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
