On Thu, Mar 24, 2016 at 10:24:49PM +0000, Chris Wilson wrote: > On Thu, Mar 24, 2016 at 12:18:49PM +0000, Tvrtko Ursulin wrote: > > @@ -2016,6 +2015,8 @@ void intel_logical_ring_cleanup(struct > > intel_engine_cs *engine) > > if (!intel_engine_initialized(engine)) > > return; > > > > + tasklet_kill(&engine->irq_tasklet); > > Imre suggested that we assert that the irq_tasklet is idle. > WARN_ON(test_bit(TASK_STATE_SCHED, &engine->irq_tasklet.state));
Whilst it may not be necessary in cleanup(), we should put a tasklet_kill() in i915_reset_engine_cleanup() -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
