On 22/12/15 10:07, ankitprasad.r.sha...@intel.com wrote:
From: Ankitprasad Sharma <ankitprasad.r.sha...@intel.com>

This patch verifies if the contents of the stolen backed object were
preserved across hibernation. This is to validate kernel changes related
to moving stolen-backed objects to shmem on hibernation.

v2: Added comment, Use igt_assert_eq() instead of igt_assert(), Made loops
more readable (Tvrtko)

Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sha...@intel.com>
---
  tests/gem_stolen.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 98 insertions(+)

diff --git a/tests/gem_stolen.c b/tests/gem_stolen.c
index 5dc2117..8a0bcb7 100644
--- a/tests/gem_stolen.c
+++ b/tests/gem_stolen.c
@@ -290,6 +290,101 @@ static void stolen_fill_purge_test(int fd)
                gem_close(fd, handle[i]);
  }

+static void stolen_hibernate(int fd)
+{
+       drm_intel_bo *bo;
+       drm_intel_bo *src, *dest;
+       int obj_count = 0, i = 0;
+       int ret, j;
+       uint32_t handle[MAX_OBJECTS], src_handle;
+       uint32_t *virt;
+
+       gem_require_stolen_support(fd);
+
+       src_handle = gem_create(fd, SIZE);
+       src = gem_handle_to_libdrm_bo(bufmgr, fd,
+                                    "bo", src_handle);
+       igt_assert(src != NULL);
+
+       ret = drm_intel_gem_bo_map_gtt(src);
+       igt_assert_eq(ret, 0);
+
+       virt = src->virtual;
+       for (j = 0; j < SIZE/DWORD_SIZE; j++) {
+               igt_assert_eq(virt[j], 0);
+               virt[j] = j;
+       }
+
+       drm_intel_bo_unmap(src);
+       /* Exhaust Stolen space */
+       for (i = 0; i < MAX_OBJECTS; i++) {
+               handle[i] = __gem_create_stolen(fd, SIZE);
+               if (!handle[i])
+                       break;
+
+               bo = gem_handle_to_libdrm_bo(bufmgr, fd,
+                                            "verify_bo", handle[i]);
+               igt_assert(bo != NULL);
+               ret = drm_intel_gem_bo_map_gtt(bo);
+               igt_assert_eq(ret, 0);
+
+               virt = bo->virtual;
+               for (j = 0; j < SIZE/DWORD_SIZE; j++)
+                       igt_assert_eq(virt[j], 0);
+
+               drm_intel_bo_unmap(bo);
+               drm_intel_bo_unreference(bo);
+
+               obj_count++;
+       }
+
+       /* Assert if atleast one object is allocated from stolen, that
+        * is good enough to verify the content preservation across
+        * hibernation.
+        */
+       igt_assert(obj_count > 0);
+
+       /* Copy data to all stolen backed objects */
+       for (i = 0; i < obj_count; i++) {
+               dest = gem_handle_to_libdrm_bo(bufmgr, fd,
+                                              "dst_bo", handle[i]);
+               igt_assert(dest != NULL);
+               intel_copy_bo(batch, dest, src, SIZE);
+               ret = drm_intel_gem_bo_map_gtt(dest);
+               igt_assert_eq(ret, 0);
+               virt = dest->virtual;
+               for (j = 0; j < SIZE/DWORD_SIZE; j++)
+                       igt_assert_eq(virt[j], j);
+
+               drm_intel_bo_unmap(dest);
+               drm_intel_bo_unreference(dest);
+       }
+
+       drm_intel_bo_unreference(src);
+
+       igt_system_hibernate_autoresume();
+       /* Check if the object's memory contents are intact
+        * across hibernation.
+        */
+       for (i = 0; i < obj_count; i++) {
+               bo = gem_handle_to_libdrm_bo(bufmgr, fd,
+                                            "verify_bo", handle[i]);
+               igt_assert(bo != NULL);
+               ret = drm_intel_gem_bo_map_gtt(bo);
+               igt_assert_eq(ret, 0);
+               virt = bo->virtual;
+               for (j = 0; j < SIZE/DWORD_SIZE; j++)
+                       igt_assert_eq(virt[j], DATA);

How did it pass this assert?

I'll assume you actually ran the test and just managed to send the wrong version out. :)

+
+               drm_intel_bo_unmap(bo);
+               drm_intel_bo_unreference(bo);
+       }
+
+       gem_close(fd, src_handle);
+       for (i = 0; i < obj_count; i++)
+               gem_close(fd, handle[i]);
+}
+
  static void
  stolen_no_mmap(int fd)
  {
@@ -353,6 +448,9 @@ igt_main
        igt_subtest("stolen-fill-purge")
                stolen_fill_purge_test(fd);

+       igt_subtest("stolen-hibernate")
+               stolen_hibernate(fd);
+
        igt_fixture {
                intel_batchbuffer_free(batch);
                drm_intel_bufmgr_destroy(bufmgr);


Fix the above assert and you can put:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to