In certain platforms we face strange and different issues
when activating PSR right after a modeset so quickly.
So we delayed the first activation for the platforms
where we saw the issues with 'commit d0ac896a477d
("drm/i915: Delay first PSR activation.")'.

So, let's apply the same delay on first activation
for SKL+ so we avoid any kind of confusion and
handle similar implentations in the same way.

Cc: Durgadoss R <durgados...@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 465d36b..38ea4d0 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -420,9 +420,6 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 
                /* Enable PSR on the panel */
                hsw_psr_enable_sink(intel_dp);
-
-               if (INTEL_INFO(dev)->gen >= 9)
-                       intel_psr_activate(intel_dp);
        } else {
                vlv_psr_setup_vsc(intel_dp);
 
@@ -441,15 +438,14 @@ void intel_psr_enable(struct intel_dp *intel_dp)
        /*
         * FIXME: Activation should happen immediately since this function
         * is just called after pipe is fully trained and enabled.
-        * However on every platform we face issues when first activation
+        * However on some platforms we face issues when first activation
         * follows a modeset so quickly.
         *     - On VLV/CHV we get bank screen on first activation
         *     - On HSW/BDW we get a recoverable frozen screen until next
         *       exit-activate sequence.
         */
-       if (INTEL_INFO(dev)->gen < 9)
-               schedule_delayed_work(&dev_priv->psr.work,
-                                     
msecs_to_jiffies(intel_dp->panel_power_cycle_delay * 5));
+       schedule_delayed_work(&dev_priv->psr.work,
+                             
msecs_to_jiffies(intel_dp->panel_power_cycle_delay * 5));
 
        dev_priv->psr.enabled = intel_dp;
 unlock:
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to