On Tue, Oct 20, 2015 at 11:49:51AM -0200, Paulo Zanoni wrote: > This thing where we need to get the crtc either from the work > structure or the fbc structure itself is confusing and unnecessary. > Set fbc.crtc right when scheduling the enable work so we can always > use it.
Pardon? It was confusing to have the crtc passed along with the work item as opposed to digging it out from an indirect link on the dev_priv. iirc work->crtc was part of the serialisation of the work item. What I think you meant was that you were passing around the wrong struct, e.g. intel_fbc_enable() just wants the crtc, in intel_fbc_flip_prepare() you check for the work struct, and then you should just use the work struct. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
