-----Original Message-----
From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of 
Daniel Vetter
Sent: Tuesday, May 26, 2015 4:27 PM
To: Morton, Derek J
Cc: intel-gfx; Wood, Thomas
Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/tests/igt_segfault.c Add unit test 
to test segfault handling

>On Tue, May 26, 2015 at 5:05 PM, Derek Morton <derek.j.mor...@intel.com> wrote:
>> + * The test consists of three subtests. The first and third should 
>> + pass
>> + * while the second should cause a segfault.
>> + * The overall result should be a failure with two subtests passing.

>You need to split this up into separate binaries and mark the expected failure 
>with XFAIL_TESTS. Or write a short wrapper for it that checks that we get the 
>right kind of failure ...

The aim of the test was to ensure the overall test returns an failure code if a 
subtest segfaults. I put a passing subtest before and after the one that 
crashes to test that the crashing subtest does not affect the other subtests. I 
guess I could write a script to check the individual subtest results.

>Yeah, autoconf library tests aren't awesome I know.
>-Daniel
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to