On Wed, 2015-05-20 at 10:37 +0300, Jani Nikula wrote: > On Wed, 20 May 2015, Ander Conselvan de Oliveira > <ander.conselvan.de.olive...@intel.com> wrote: > > Explain why a few fields of the new pipe_config have their values > > preserved, while the others are zeroed. > > > > Signed-off-by: Ander Conselvan de Oliveira > > <ander.conselvan.de.olive...@intel.com> > > --- > > drivers/gpu/drm/i915/intel_display.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index a7732b4..b0cd649 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -11460,7 +11460,11 @@ clear_intel_crtc_state(struct intel_crtc_state > > *crtc_state) > > enum intel_dpll_id shared_dpll; > > uint32_t ddi_pll_sel; > > > > - /* Clear only the intel specific part of the crtc state excluding > > scalers */ > > + /* FIXME: before the switch to atomic started, a new pipe_config was > > + * kzalloc'd. Code that depends on any field being zero should be > > + * fixed, so that the crtc_state can be safely duplicated. For now, > > + * only fields that are know to not cause problems are preserved. */ > > + > > Nitpick, the opening /* and at least the closing */ should be on their > own lines.
I've seen a mix of both styles through-out the driver, so it wasn't clear to me that's preferred. I'll follow that from now on. Thanks, Ander > > > tmp_state = crtc_state->base; > > scaler_state = crtc_state->scaler_state; > > shared_dpll = crtc_state->shared_dpll; > > -- > > 2.1.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
