On Fri, May 15, 2015 at 02:08:22AM +0530, Ramalingam C wrote:
> After scheduling a flip for obj, we are supposed to invalidate the
> drrs.
> 
> Action:
>     Adding a call to intel_edp_drrs_invalidate at
>     intel_frontbuffer_flip_prepare.
> 
> Signed-off-by: Ramalingam C <ramalinga...@intel.com>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>

Just Cc: Chris Wilson <ch...@chris-wilson.co.uk>
References: https://bugs.freedesktop.org/show_bug.cgi?id=90418

Ok, looks correct. This invalidate will be paired with a flush after the
flip completes to reschedule the downclock of the refresh rates.

I think a comment would be useful to explain the relationship here, or
better would be a new intel_edp_drrs_flip_prepare() stub so that the
internal details of drrs are kept out of intel_frontbuffer.c and the
comment can refer to the adjacent functions for reference.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to