> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Daniel Vetter > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > b/drivers/gpu/drm/i915/i915_reg.h > > index b65bdfc..a70f12e 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -6661,4 +6661,17 @@ enum punit_power_well { > > #define _PALETTE_A (dev_priv->info.display_mmio_offset + 0xa000) > > #define _PALETTE_B (dev_priv->info.display_mmio_offset + 0xa800) > > > > +/* The MMIO offset of the shared info between i915 and vgt driver */ > > +#define VGT_PVINFO_PAGE 0x78000 > > +#define VGT_PVINFO_SIZE 0x1000 > > + > > +#define VGT_MAGIC 0x4776544776544776 /* 'vGTvGTvG' */ > > +#define VGT_VERSION_MAJOR 1 > > +#define VGT_VERSION_MINOR 0 > > +#define INTEL_VGT_IF_VERSION ((VGT_VERSION_MAJOR << 16) | > VGT_VERSION_MINOR) > > + > > +#define vgt_info_off(x) \ > > + (VGT_PVINFO_PAGE + (long)&((struct vgt_if *) NULL)->x) > > I think a new header file i915_vgt.h for these definitions would be good. > i915_reg.h is giant already ... > -Daniel >
sure we can follow this suggestion. Actually our original implementation has the definition separately defined. Just because we saw current i915 has a single register definition header, so thought we should adapt to that. :-) Thanks Kevin _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
