Well, this fix the issue Linus faced. Actually the issue I was aware of and trying to fix with this patch for a long time was reported by chromeos guys saying the psr wasn't propperly working after suspend/resume. They got the screen back but never got psr back again.
The original patch fix suspend/resume issues with psr and I decided to keep the same and subject for reference of what the problem this fixes and what was the patch history, but changed the place for the full setup to crtc_enable per your recommendation. Thanks, Rodrigo. On Sat, Aug 9, 2014 at 12:40 AM, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > On Fri, Aug 8, 2014 at 7:19 PM, Rodrigo Vivi <rodrigo.v...@intel.com> > wrote: > > From: Rodrigo Vivi <rodrigo.v...@gmail.com> > > > > Some registers set during setup might not be persistent after > suspend/resume. > > This was causing bugs for some people that was unable to get PSR entry > state > > after resume cycle. > > > > v2: Adding some comments and better commit message explaining why this > is needed. > > v3: Getting back old setup_done variable and move from resume to > crtc_enable > > as Daniel requested. > > > > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > > I'm confused ... whats the use of this? Afaict that's exactly what the > code currently does. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > -- Rodrigo Vivi Blog: http://blog.vivi.eng.br
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
