On Mon, 2014-06-02 at 10:45 +0200, Daniel Vetter wrote: > On Thu, May 29, 2014 at 02:11:37PM -0700, Jesse Barnes wrote: > > From: Kristen Carlson Accardi <kris...@linux.intel.com> > > > > This matches the runtime suspend paths and allows the system to enter > > the lowest power mode at freeze time. > > > > Signed-off-by: Kristen Carlson Accardi <kris...@linux.intel.com> > > Signed-off-by: Jesse Barnes <jbar...@virtuousgeek.org> > > pc8 is fully subsumed into runtime pm by now. Do we _really_ still need > this?
Yes, since the system suspend/resume handlers are called with an RPM ref
held and thus PC8 disabled.
--Imre
> -Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c
> > b/drivers/gpu/drm/i915/i915_drv.c
> > index b6211d7..24dc856 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -558,6 +558,9 @@ static int i915_drm_freeze(struct drm_device *dev)
> >
> > intel_display_set_init_power(dev_priv, false);
> >
> > + if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> > + hsw_enable_pc8(dev_priv);
> > +
> > return 0;
> > }
> >
> > @@ -618,6 +621,9 @@ static int __i915_drm_thaw(struct drm_device *dev, bool
> > restore_gtt_mappings)
> > {
> > struct drm_i915_private *dev_priv = dev->dev_private;
> >
> > + if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> > + hsw_disable_pc8(dev_priv);
> > +
> > if (drm_core_check_feature(dev, DRIVER_MODESET) &&
> > restore_gtt_mappings) {
> > mutex_lock(&dev->struct_mutex);
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
