> Subject: Re: [PATCH v3 14/26] drm/i915/writeback: Define function to destroy
> writeback connector
>
> On Wed, Mar 25, 2026 at 04:37:32PM +0530, Suraj Kandpal wrote:
> > Define function to destroy the drm_writbeack_connector and
> > drm_connector associated with it.
> >
> > Signed-off-by: Suraj Kandpal <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_writeback.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_writeback.c
> > b/drivers/gpu/drm/i915/display/intel_writeback.c
> > index e677cdfa6207..86b53e4603ae 100644
> > --- a/drivers/gpu/drm/i915/display/intel_writeback.c
> > +++ b/drivers/gpu/drm/i915/display/intel_writeback.c
> > @@ -161,6 +161,12 @@ intel_writeback_detect(struct drm_connector
> *connector,
> > return connector_status_connected;
> > }
> >
> > +static void intel_writeback_connector_destroy(struct drm_connector
> > +*connector) {
> > + drm_connector_cleanup(connector);
> > + kfree(connector);
> > +}
>
> Please squash with the patch that added the init/allocation.
Will do.
Regards,
Suraj Kandpal
>
> > +
> > static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
> > .destroy = drm_encoder_cleanup,
> > };
> > @@ -170,6 +176,7 @@ const struct drm_connector_funcs conn_funcs = {
> > .fill_modes = drm_helper_probe_single_connector_modes,
> > .atomic_duplicate_state = intel_digital_connector_duplicate_state,
> > .atomic_destroy_state =
> drm_atomic_helper_connector_destroy_state,
> > + .destroy = intel_writeback_connector_destroy,
> > };
> >
> > static const struct drm_connector_helper_funcs conn_helper_funcs = {
> > --
> > 2.34.1
>
> --
> Ville Syrjälä
> Intel
