On Fri, 13 Mar 2026, Ville Syrjälä <[email protected]> wrote: > On Wed, Mar 11, 2026 at 05:05:54PM +0530, Ankit Nautiyal wrote: >> Align the DP_DPRX feature enumeration macros for better readability and >> consistency, and use the BIT() macro instead of open-coded shifts. >> >> Signed-off-by: Ankit Nautiyal <[email protected]> > > If we really want to go for BIT() someone should do a full pass > over the whole file...
Should also use BIT_U8() and GENMASK_U8(). > > In the meantime > Reviewed-by: Ville Syrjälä <[email protected]> > >> --- >> include/drm/display/drm_dp.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h >> index 4ea3b5b08a12..49f0154eb93c 100644 >> --- a/include/drm/display/drm_dp.h >> +++ b/include/drm/display/drm_dp.h >> @@ -1202,10 +1202,10 @@ >> # define DP_DPRX_SLEEP_WAKE_TIMEOUT_PERIOD_80_MS 0x04 >> # define DP_DPRX_SLEEP_WAKE_TIMEOUT_PERIOD_100_MS 0x05 >> >> -#define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 0x2214 /* 2.0 E11 */ >> -# define DP_ADAPTIVE_SYNC_SDP_SUPPORTED (1 << 0) >> -# define DP_AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED >> (1 << 1) >> -# define DP_VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (1 << 4) >> +#define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 >> 0x2214 /* 2.0 E11 */ >> +# define DP_ADAPTIVE_SYNC_SDP_SUPPORTED >> BIT(0) >> +# define DP_AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED >> BIT(1) >> +# define DP_VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED >> BIT(4) >> >> #define DP_128B132B_SUPPORTED_LINK_RATES 0x2215 /* 2.0 */ >> # define DP_UHBR10 (1 << 0) >> -- >> 2.45.2 -- Jani Nikula, Intel
