> -----Original Message-----
> From: Govindapillai, Vinod <[email protected]>
> Sent: Friday, February 20, 2026 10:39 PM
> To: [email protected]; [email protected]
> Cc: Govindapillai, Vinod <[email protected]>; Syrjala, Ville
> <[email protected]>; Shankar, Uma <[email protected]>
> Subject: [PATCH v2 1/6] drm/xe/fbdev: Fix BIOS FB vs.s stolen size check

Nit: Change "vs.s" to "vs".

> From: Ville Syrjälä <[email protected]>
> 
> Looks like stolen->size is in bytes, not pages. Remove the bogus PAGE_SHIFT
> stuff.
> 
> Also for some rnadom reason xe rejects the FB if it takes up exactly half of 
> stolen,

Typo in random.

> whereas i915 allows it to be used in that case. Adjust xe to follow the i915 
> rule for
> consistency.
> 
> v2: rebase related updates
> 
> Signed-off-by: Ville Syrjälä <[email protected]>
> Reviewed-by: Uma Shankar <[email protected]>
> Signed-off-by: Vinod Govindapillai <[email protected]>
> ---
>  drivers/gpu/drm/xe/display/xe_initial_plane.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_initial_plane.c
> b/drivers/gpu/drm/xe/display/xe_initial_plane.c
> index 4cfeafcc158d..38ecc201ac4e 100644
> --- a/drivers/gpu/drm/xe/display/xe_initial_plane.c
> +++ b/drivers/gpu/drm/xe/display/xe_initial_plane.c
> @@ -99,7 +99,7 @@ initial_plane_bo(struct xe_device *xe,
>                * features.
>                */
>               if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) &&
> -                 plane_config->size * 2 >> PAGE_SHIFT >= stolen->size)
> +                 plane_config->size * 2 > stolen->size)
>                       return NULL;
>       }
> 
> --
> 2.43.0

Reply via email to