On Tue, 16 Sep 2025, S Sebinraj <s.sebin...@intel.com> wrote:
> Moved the trace file header to appropriate path "include/drm" and
> updated the code as per the same.
> You're not supposed to address code review in independent patches but rather
> modify the original patches. This is kernel development basics.
> BR,
> Jani.
Okay got it, so now do I need to go back and make the changes in original patch
and then raise again or this would be fine for now ?
Please let me know.
>
> Signed-off-by: S Sebinraj <s.sebin...@intel.com>
> ---
> drivers/gpu/drm/drm_gpu_frequency_trace.c | 2 +-
> drivers/gpu/drm/xe/xe_gpu_freq_trace.h | 2 +-
> {drivers/gpu => include}/drm/drm_gpu_frequency_trace.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-) rename {drivers/gpu
> => include}/drm/drm_gpu_frequency_trace.h (96%)
>
> diff --git a/drivers/gpu/drm/drm_gpu_frequency_trace.c
> b/drivers/gpu/drm/drm_gpu_frequency_trace.c
> index b5fa5134226d..e33df068752d 100644
> --- a/drivers/gpu/drm/drm_gpu_frequency_trace.c
> +++ b/drivers/gpu/drm/drm_gpu_frequency_trace.c
> @@ -9,7 +9,7 @@
> #ifdef CONFIG_DRM_GPU_FREQUENCY_TRACE
>
> #define CREATE_TRACE_POINTS
> -#include "drm_gpu_frequency_trace.h"
> +#include <drm/drm_gpu_frequency_trace.h>
>
> EXPORT_TRACEPOINT_SYMBOL_GPL(gpu_frequency);
>
> diff --git a/drivers/gpu/drm/xe/xe_gpu_freq_trace.h
> b/drivers/gpu/drm/xe/xe_gpu_freq_trace.h
> index f188d529ae60..c15d41761296 100644
> --- a/drivers/gpu/drm/xe/xe_gpu_freq_trace.h
> +++ b/drivers/gpu/drm/xe/xe_gpu_freq_trace.h
> @@ -6,7 +6,7 @@
> #ifndef _XE_GPU_FREQ_TRACE_H_
> #define _XE_GPU_FREQ_TRACE_H_
>
> -#include "../drm_gpu_frequency_trace.h"
> +#include <drm/drm_gpu_frequency_trace.h>
>
> /* Convert MHz to KHz for tracepoint */
> #define MHZ_TO_KHZ(freq_mhz) ((freq_mhz) * 1000)
> diff --git a/drivers/gpu/drm/drm_gpu_frequency_trace.h
> b/include/drm/drm_gpu_frequency_trace.h
> similarity index 96%
> rename from drivers/gpu/drm/drm_gpu_frequency_trace.h
> rename to include/drm/drm_gpu_frequency_trace.h
> index cf6337847b3a..47f32fd295a4 100644
> --- a/drivers/gpu/drm/drm_gpu_frequency_trace.h
> +++ b/include/drm/drm_gpu_frequency_trace.h
> @@ -42,6 +42,6 @@ static inline void trace_gpu_frequency(unsigned int
> state, unsigned int gpu_id)
>
> #ifdef CONFIG_DRM_GPU_FREQUENCY_TRACE #undef TRACE_INCLUDE_PATH
> -#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm
> +#define TRACE_INCLUDE_PATH ../../include/drm
> #include <trace/define_trace.h>
> #endif
--
Jani Nikula, Intel
