This is v2 of [1]. There were issues with sideband get/put, discovered in CI, so I ended up doing what Ville suggested in [2], and handling sideband get/put inside the functions. This is done in new patches 1-2, which obviously caused some rebase churn in the rest. I also removed vlv_get_cck_clock_hpll() completely, this is new patch 11.
I added r-b/ack from the previous version in some patches, dropped them from others, depending on how much changes there were. Sorry about the trouble, please look into this again. BR, Jani. [1] https://lore.kernel.org/r/cover.1755607980.git.jani.nik...@intel.com [2] https://lore.kernel.org/r/amaqlvaw2nqlw...@intel.com Jani Nikula (15): drm/i915: do cck get/put inside vlv_get_hpll_vco() drm/i915: do cck get/put inside vlv_get_cck_clock() drm/i915: add vlv_clock_get_gpll() drm/i915: add vlv_clock_get_czclk() drm/i915: add vlv_clock_get_hrawclk() drm/i915: make vlv_get_cck_clock_hpll() static drm/i915: add vlv_clock_get_cdclk() drm/i915: make vlv_get_cck_clock() static drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco() drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it more drm/i915: remove vlv_get_cck_clock_hpll() drm/i915: remove intel_update_czclk() as unnecessary drm/i915: log HPLL frequency similar to CZCLK drm/i915: move hpll and czclk caching under display drm/i915: split out vlv_clock.[ch] drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_cdclk.c | 36 +++------ drivers/gpu/drm/i915/display/intel_display.c | 61 -------------- drivers/gpu/drm/i915/display/intel_display.h | 6 -- .../gpu/drm/i915/display/intel_display_core.h | 5 ++ .../drm/i915/display/intel_display_driver.c | 1 - drivers/gpu/drm/i915/display/vlv_clock.c | 81 +++++++++++++++++++ drivers/gpu/drm/i915/display/vlv_clock.h | 38 +++++++++ drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +- drivers/gpu/drm/i915/gt/intel_rps.c | 18 ++--- drivers/gpu/drm/i915/i915_drv.h | 3 - drivers/gpu/drm/xe/xe_device_types.h | 6 -- 12 files changed, 145 insertions(+), 114 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.c create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.h -- 2.47.3