Quoting Matt Atwood (2025-09-03 14:08:21-03:00)
>The checks in plane_has_modifier() should check against display version
>instead of graphics version.
>
>Bspec: 67165, 70815
>
>Signed-off-by: Matt Atwood <matthew.s.atw...@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_fb.c
>b/drivers/gpu/drm/i915/display/intel_fb.c
>index b210c3250501..1e4cee857d7b 100644
>--- a/drivers/gpu/drm/i915/display/intel_fb.c
>+++ b/drivers/gpu/drm/i915/display/intel_fb.c
>@@ -563,11 +563,11 @@ static bool plane_has_modifier(struct intel_display
>*display,
> return false;
>
> if (md->modifier == I915_FORMAT_MOD_4_TILED_BMG_CCS &&
>- (GRAPHICS_VER(i915) < 20 || !display->platform.dgfx))
>+ (DISPLAY_VER(display) < 14 || !display->platform.dgfx))
> return false;
>
> if (md->modifier == I915_FORMAT_MOD_4_TILED_LNL_CCS &&
>- (GRAPHICS_VER(i915) < 20 || display->platform.dgfx))
>+ (DISPLAY_VER(display) < 20 || display->platform.dgfx))
> return false;
Hm... Maybe using GRAPHICS_VER() here was intentional? The checks on
display version are already covered by the entries in intel_modifiers.
If we look at commit fca0abb23447 ("drm/i915/display: allow creation of
Xe2 ccs framebuffers"), we'll see that the respective entries were added
to intel_modifiers *and* the checks on GRAPHICS_VER() were added as
well. Perhaps there are indeed restrictions on the graphics side to be
able to use the format?
--
Gustavo Sousa
>
> return true;
>--
>2.50.1
>
