Hi Steven, On 2025-08-28 at 16:39:23 +0100, Steven Price wrote: > On 28/08/2025 14:03, Daniel Almeida wrote:
In subject please add a fuller name what you improve, as this is only one lib here, so a sligtly better: [PATCH i-g-t 1/4] lib/drmtest: add support for Panthor devices > > We will be adding tests for Panthor in a subsequent patch, so first add > > the ability to open the device. > > > > Signed-off-by: Daniel Almeida <[email protected]> > > There's also chipset_to_str() which should be updated to return the > correct name. Although I think that only makes some error messages prettier. Looks like something to improve, now I think driver name should not be repeated in two places. I will sent a patch for this function soon. Regards, Kamil > > I'm not familiar enough with IGT to really provide a proper review, but > I gave the tests a spin. See my comments on patch 4 for the bugs I hit ;) > > Steve > > > --- > > lib/drmtest.c | 1 + > > lib/drmtest.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/lib/drmtest.c b/lib/drmtest.c > > index 436b6de78..f4b429048 100644 > > --- a/lib/drmtest.c > > +++ b/lib/drmtest.c > > @@ -220,6 +220,7 @@ static const struct module { > > { DRIVER_INTEL, "i915", modprobe_i915 }, > > { DRIVER_MSM, "msm" }, > > { DRIVER_PANFROST, "panfrost" }, > > + { DRIVER_PANTHOR, "panthor" }, > > { DRIVER_V3D, "v3d" }, > > { DRIVER_VC4, "vc4" }, > > { DRIVER_VGEM, "vgem" }, > > diff --git a/lib/drmtest.h b/lib/drmtest.h > > index 27e5a18e2..1a933eae1 100644 > > --- a/lib/drmtest.h > > +++ b/lib/drmtest.h > > @@ -55,6 +55,7 @@ int __get_drm_device_name(int fd, char *name, int > > name_size); > > #define DRIVER_MSM (1 << 6) > > #define DRIVER_XE (1 << 7) > > #define DRIVER_VMWGFX (1 << 8) > > +#define DRIVER_PANTHOR (1 << 9) > > > > /* > > * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system >
