> -----Original Message-----
> From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Jouni
> Högander
> Sent: Wednesday, August 13, 2025 12:36 PM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogan...@intel.com>
> Subject: [PATCH 2/4] drm/i915/alpm: Add own define for LFPS count
>
> Add own define for LFPS count and use it for the configuration. This new
> define will be used for calculating ALPM parameters as well.
>
> Signed-off-by: Jouni Högander <jouni.hogan...@intel.com>
LGTM.
Reviewed-by: Animesh Manna <animesh.ma...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index e48a4218c163..ae556a885c2a 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -22,6 +22,8 @@
> (SILENCE_PERIOD_MAX_TIME - \
> SILENCE_PERIOD_MIN_TIME) / 2)
>
> +#define LFPS_CYCLE_COUNT 10
> +
> bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp) {
> return intel_dp->alpm_dpcd & DP_ALPM_CAP; @@ -403,7 +405,7
> @@ void intel_alpm_port_configure(struct intel_dp *intel_dp,
> PORT_ALPM_CTL_MAX_PHY_SWING_HOLD(0) |
> PORT_ALPM_CTL_SILENCE_PERIOD(
> intel_dp-
> >alpm_parameters.silence_period_sym_clocks);
> - lfps_ctl_val = PORT_ALPM_LFPS_CTL_LFPS_CYCLE_COUNT(10)
> |
> + lfps_ctl_val =
> PORT_ALPM_LFPS_CTL_LFPS_CYCLE_COUNT(LFPS_CYCLE_COUNT)
> +|
>
> PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION(
> intel_dp-
> >alpm_parameters.lfps_half_cycle_num_of_syms) |
>
> PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION(
> --
> 2.43.0
