RE: [PATCH] drm/i915/vrr: Drop redundant HAS_VRR checks

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>
> Sent: 25 August 2025 19:28
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; jani.nik...@linux.intel.com; Golani,
> Mitulkumar Ajitkumar <mitulkumar.ajitkumar.gol...@intel.com>; Nautiyal,
> Ankit K <ankit.k.nauti...@intel.com>
> Subject: [PATCH] drm/i915/vrr: Drop redundant HAS_VRR checks
> 
> We fill crtc_state->vrr.flipline only when HAS_VRR() returns true.
> This makes HAS_VRR() check redundant in places where we are already
> checking for intel_vrr_possible(), which returns true only if vrr.flipline is 
> set.
> 
> Drop such HAS_VRR() checks to simplify the logic.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 3eed37f271b0..b9061cbb67d5 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -652,9 +652,6 @@ void intel_vrr_transcoder_enable(const struct
> intel_crtc_state *crtc_state)
>       struct intel_display *display = to_intel_display(crtc_state);
>       enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> 
> -     if (!HAS_VRR(display))
> -             return;
> -
>       if (!intel_vrr_possible(crtc_state))
>               return;
> 
> @@ -678,9 +675,6 @@ void intel_vrr_transcoder_disable(const struct
> intel_crtc_state *crtc_state)
>       struct intel_display *display = to_intel_display(crtc_state);
>       enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> 
> -     if (!HAS_VRR(display))
> -             return;
> -

Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>

>       if (!intel_vrr_possible(crtc_state))
>               return;
> 
> --
> 2.45.2