________________________________ From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> on behalf of Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> Sent: Friday, August 22, 2025 9:14:20 pm To: intel-gfx@lists.freedesktop.org <intel-gfx@lists.freedesktop.org>; intel...@lists.freedesktop.org <intel...@lists.freedesktop.org> Cc: Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> Subject: [PATCH] drm/i915/display: handle return value in intel_sdvo_enable_hotplug
Report in log if intel_sdvo_enable_hotplug failed Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> --- drivers/gpu/drm/i915/display/intel_sdvo.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index 87aff2754f69..99a5ef1401a8 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -2052,8 +2052,10 @@ static void intel_sdvo_enable_hotplug(struct intel_encoder *encoder) { struct intel_sdvo *intel_sdvo = to_sdvo(encoder); - intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG, - &intel_sdvo->hotplug_active, 2); + if (!intel_sdvo_write_cmd(intel_sdvo, SDVO_CMD_SET_ACTIVE_HOT_PLUG, + &intel_sdvo->hotplug_active, 2)) + drm_warn(intel_sdvo->base.base.dev, + "Failed to enable hotplug on SDVO encoder\n"); } static enum intel_hotplug_state -- 2.43.0