> -----Original Message-----
> From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Tuesday, 5 August 2025 12.18
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nik...@intel.com>
> Subject: [PATCH 01/12] drm/i915: add vlv_clock_get_gpll()
>
> Add a vlv_clock_get_gpll() helper to hide the details from the callers.
>
Reviewed-by: Mika Kahola <mika.kah...@intel.com>
> Signed-off-by: Jani Nikula <jani.nik...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 8 ++++++++
> drivers/gpu/drm/i915/display/intel_display.h | 1 +
> drivers/gpu/drm/i915/gt/intel_rps.c | 5 +----
> 3 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 7035c1fc9033..fdd29d9256ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -186,6 +186,14 @@ int vlv_get_cck_clock_hpll(struct drm_device *drm,
> return hpll;
> }
>
> +int vlv_clock_get_gpll(struct drm_device *drm) {
> + struct drm_i915_private *i915 = to_i915(drm);
> +
> + return vlv_get_cck_clock(drm, "GPLL ref", CCK_GPLL_CLOCK_CONTROL,
> + i915->czclk_freq);
> +}
> +
> void intel_update_czclk(struct intel_display *display) {
> struct drm_i915_private *dev_priv = to_i915(display->drm); diff --git
> a/drivers/gpu/drm/i915/display/intel_display.h
> b/drivers/gpu/drm/i915/display/intel_display.h
> index 37e2ab301a80..7ae899b8787a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -440,6 +440,7 @@ int vlv_get_cck_clock(struct drm_device *drm,
> const char *name, u32 reg, int ref_freq); int
> vlv_get_cck_clock_hpll(struct drm_device *drm,
> const char *name, u32 reg);
> +int vlv_clock_get_gpll(struct drm_device *drm);
> bool intel_has_pending_fb_unpin(struct intel_display *display); void
> intel_encoder_destroy(struct drm_encoder *encoder);
> struct drm_display_mode * diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c
> b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 0b35fdd461d4..e2b5cdf6b7cb 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -1683,10 +1683,7 @@ static void vlv_init_gpll_ref_freq(struct intel_rps
> *rps) {
> struct drm_i915_private *i915 = rps_to_i915(rps);
>
> - rps->gpll_ref_freq =
> - vlv_get_cck_clock(&i915->drm, "GPLL ref",
> - CCK_GPLL_CLOCK_CONTROL,
> - i915->czclk_freq);
> + rps->gpll_ref_freq = vlv_clock_get_gpll(&i915->drm);
>
> drm_dbg(&i915->drm, "GPLL reference freq: %d kHz\n",
> rps->gpll_ref_freq);
> --
> 2.39.5
