Hi Jeff,
[...]
> +++ b/drivers/gpu/drm/i915/intel_wakeref.c
> @@ -114,7 +114,8 @@ void __intel_wakeref_init(struct intel_wakeref *wf,
> "wakeref.work", &key->work, 0);
>
> #if IS_ENABLED(CONFIG_DRM_I915_DEBUG_WAKEREF)
> - ref_tracker_dir_init(&wf->debug, INTEL_REFTRACK_DEAD_COUNT, name);
> + if (!wf->debug.class)
> + ref_tracker_dir_init(&wf->debug, INTEL_REFTRACK_DEAD_COUNT,
> "intel_wakeref", name);
I think this line could be broken in two. It is almost 100
characters long and the majority of this file does not
exceed 90.
> #endif
> }
>
> diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
> index
> a0a1ee43724ffa00e60c116be18e481bfe1d1455..3968f993db81e95c0d58c81454311841c1b9cd35
> 100644
> --- a/include/linux/ref_tracker.h
> +++ b/include/linux/ref_tracker.h
> @@ -19,6 +19,7 @@ struct ref_tracker_dir {
> bool dead;
> struct list_head list; /* List of active trackers */
> struct list_head quarantine; /* List of dead trackers */
> + const char *class; /* object classname */
Another nitpick here: the comments start with capital letters in
this struct, so could you change object -> Object?
Apart from these minor suggestions, I think this is a nice
change:
Reviewed-by: Krzysztof Karas <krzysztof.ka...@intel.com>
---
Best Regards,
Krzysztof
