Hey,
On 2025-06-23 12:10, Jocelyn Falempe wrote:
> On 23/06/2025 09:40, Maarten Lankhorst wrote:
>> Hey,
>>
>> Thanks for the series. I didn't see you on irc so I wanted to ask if you are
>> planning to send a v11 with
>> the changes from void * to struct intel_panic_data and adding the VRAM
>> support?
>
> Yes, I'm preparing a v11, and I'm considering to do something like this, to
> allocate the panic data with the struct intel_framebuffer:
>
> struct xe_framebuffer {
> struct intel_framebuffer base;
> struct xe_panic_data panic;
> };
>
> struct intel_framebuffer *intel_bo_alloc_framebuffer(void)
> {
> struct xe_framebuffer *xe_fb;
>
> xe_fb = kmalloc(sizeof(struct xe_framebuffer), GFP_KERNEL);
> return &xe_fb->base;
> }
>
> (And the same for i915).
> That should allow you to add battlemage support.
>
>>
>>
>> Other than that, I think the series looks good and I'll be able to test it
>> on my battlemage.
>>
A private member is fine, but if you can get signoff from the i915 people for
the xe_fb slpit, I would really like that for other things too. :)
Kind regards,
~Maarten
