On Thu, Mar 06, 2025 at 12:42:07PM +0200, Jani Nikula wrote: > Side note, I often pipe messages from my MUA (notmuch-emacs) to b4, as > it nicely parses the mails and picks up the message-id from > there. Overall it works great. However, b4 seems to err on the side of > writing color codes to pipes, and I get this as output: > > --- > [32m✓[0m [PATCH v5->v6 1/6] drm/i915/hpd: Track HPD pins instead of ports > for HPD pulse events > + Reviewed-by: Jani Nikula <jani.nik...@intel.com> ([32m✓[0m > DKIM/intel.com) > [32m✓[0m [PATCH v5->v6 2/6] drm/i915/hpd: Let an HPD pin be in the disabled > state when handling missed IRQs > + Reviewed-by: Jani Nikula <jani.nik...@intel.com> ([32m✓[0m > DKIM/intel.com) > [32m✓[0m [PATCH v6 3/6] drm/i915/hpd: Add support for blocking the IRQ > handling on an HPD pin > [32m✓[0m [PATCH v5->v6 4/6] drm/i915/dp: Fix link training interrupted by a > short HPD pulse > + Reviewed-by: Jani Nikula <jani.nik...@intel.com> ([32m✓[0m > DKIM/intel.com) > [32m✓[0m [PATCH v6 5/6] drm/i915/dp: Queue a link check after link > training is complete > [32m✓[0m [PATCH v5->v6 6/6] drm/i915/crt: Use intel_hpd_block/unblock() > instead of intel_hpd_disable/enable() > --- > [32m✓[0m Signed: DKIM/intel.com > --- > > I haven't had the time to dig into b4 source on this, but it would be > great if it could automatically detect whether sending colors is the > right thing to do or not. Basically only emit color codes to interactive > terminals, unless forced also for pipes.
Yes, it should do that automatically. Please send a bug report to to...@kernel.org and I'll work an automated switch to "simple" attestation marks when we don't have a terminal. -K
