On Thu, Mar 06, 2025 at 06:40:55PM +0530, Ankit Nautiyal wrote:
> For fixed refresh rate use fixed timings for all platforms that support
> VRR. For this add checks to avoid computing and reading VRR for
> platforms that do not support VRR.
>
> v2: Avoid touching check for VRR_CTL_FLIP_LINE_EN. (Ville)
> v3: Avoid redundant statements in vrr_{compute/get}_config. (Ville)
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vrr.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index d7580b6e4e37..efa26a39b86a 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -351,6 +351,9 @@ intel_vrr_compute_config(struct intel_crtc_state
> *crtc_state,
> struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
> int vmin, vmax;
>
> + if (!HAS_VRR(display))
> + return;
> +
> /*
> * FIXME all joined pipes share the same transcoder.
> * Need to account for that during VRR toggle/push/etc.
> @@ -374,15 +377,12 @@ intel_vrr_compute_config(struct intel_crtc_state
> *crtc_state,
> vmax = vmin;
> }
>
> - if (vmin >= vmax)
> - return;
> -
> crtc_state->vrr.vmin = vmin;
> crtc_state->vrr.vmax = vmax;
>
> crtc_state->vrr.flipline = crtc_state->vrr.vmin;
>
> - if (crtc_state->uapi.vrr_enabled)
> + if (crtc_state->uapi.vrr_enabled && vmin < vmax)
> intel_vrr_compute_vrr_timings(crtc_state);
> else if (is_cmrr_frac_required(crtc_state) && is_edp)
> intel_vrr_compute_cmrr_timings(crtc_state);
> --
> 2.45.2
--
Ville Syrjälä
Intel
