> -----Original Message-----
> From: Yu, Gareth <gareth...@intel.com>
> Sent: Friday, February 21, 2025 9:44 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel...@lists.freedesktop.org; shawn.c.lee.intel.om; Tseng, William
> <william.ts...@intel.com>; Nautiyal, Ankit K <ankit.k.nauti...@intel.com>; Yu,
> Gareth <gareth...@intel.com>; Kandpal, Suraj <suraj.kand...@intel.com>;
> Heikkila, Juha-pekka <juha-pekka.heikk...@intel.com>
> Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2
> for rc params calculation
>
> From: Gareth Yu <gareth...@intel.com>
>
> The condition change is because Gen 14 begins to support DSC 1.2 and need to
> check if the sink supports DSC1.2
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
>
> Cc: Suraj Kandpal <suraj.kand...@intel.com>
> Cc: Juha-Pekka Heikkil <juha-pekka.heikk...@intel.com>
> Signed-off-by: Gareth Yu <gareth...@intel.com>
Why has the authorship and Signed-off-by changed for essentially the same patch.
Also the commit message and versioning information has been removed any changes
Needs to go as a new version to the previous patch.
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index b355c479eda3..555180e40b72 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state
> *pipe_config)
> * upto uncompressed bpp-1, hence add calculations for all the rc
> * parameters
> */
> - if (DISPLAY_VER(dev_priv) >= 13) {
> + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >=
> +2)) {
Please add a bspec reference number in the commit message where it says we
started support of DSC 1.2 from MTL
Regards,
Suraj Kandpal
> calculate_rc_params(vdsc_cfg);
> } else {
> if ((compressed_bpp == 8 ||
> --
> 2.34.1
